search

seanwash / vscode-vue-components

.vue component syntax highlighting for visual studio code
5 stars 1 forks source link

ctrl+/ comment bug #3

Closed beeplin closed 6 years ago

beeplin commented 8 years ago

best vue plugin for vs code ever~! thanks!

one issue: always insert // before a line when press ctrl \, even in the html/css/coffee... parts.

it would be better to behave like this:

if current cursor position is in a < script>...< /script> part, insert //; if in a < script ... lang="coffee"> ... < /script> part, insert # ; if in a < style.... < /style> part, insert /* ... */ otherwise: insert < !-- ... -->

seanwash commented 8 years ago

@beeplin Thanks, I'll check in on this!

seanwash commented 8 years ago

FYI this looks to be a limitation with code for now.

In the language config file we only have options for one type of line comment and one type of block comment:

{
  "comments": {
      // symbol used for single line comment. Remove this entry if your language does not support line comments
      "lineComment": "//",
      // symbols used for start and end a block comment. Remove this entry if your language does not support block comments
      "blockComment": [ "/*", "*/" ]
  }
}
beeplin commented 8 years ago

got it. seems we have to separate vue files into vue\js\css files to get better language.support.

seanwash commented 8 years ago

@beeplin Yeah I think you're right. I'll keep looking through the code repo to see if I can't find anything useful there – there are a ton of open issues so I'm sure that there's one that we can add our voices to.

seanwash commented 8 years ago

Here's a relevant open issue https://github.com/Microsoft/vscode/issues/8928