search

seanwash / vscode-vue-components

.vue component syntax highlighting for visual studio code
5 stars 1 forks source link

<style> lang attribute support (for SCSS and others) #4

Open mixedCase opened 7 years ago

mixedCase commented 7 years ago

Setting the lang attribute to the style tag (e.g. <style lang="scss">) should enable syntax highlighting support and autocompletion[1] for the specified language.

[1]: Auto-completion for regular CSS inside HTML documents has apparently been fixed in upstream VSCode, but is yet to hit stable. I have not tested wether this upstream change enables auto-completion for regular CSS in Vue components.

mixedCase commented 7 years ago

The mentioned auto-completion has now hit stable with 1.7.1, so both items should be achievable.

Pinging @seanwash

seanwash commented 7 years ago

@mixedCase ping received. I'll start reading the docs to figure out what we need to do!

Reading List

Issues/Clues

Feel free to chime in with examples where other packages might have implemented this or issue threads that might provide some clues as to the best approach.

seanwash commented 7 years ago

Also FWIW It looks like we're getting a little closer with 1.7.1 as I believe they updated the logic around using source.lang.embedded.lang settings from .tmLanguage files, which is why commenting works now.

Here's a gif showing the update. Forgive my typing, I'm currently tethering in a car 😔

https://cl.ly/1g040E2k2w01

tomByrer commented 7 years ago

There is a good test file here: https://github.com/octref/vetur/blob/master/demo/vetur.vue

rhyek commented 7 years ago

Status on this?

seanwash commented 7 years ago

No change. Check out this package instead https://marketplace.visualstudio.com/items?itemName=octref.vetur

Apologies but I just don't have the spare time to update this plugin!

+

Sean Washington hello@seanwash.com

On January 26, 2017 at 8:55:02 PM, Carlos Gonzales (notifications@github.com) wrote:

Status on this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seanwash/vscode-vue-components/issues/4#issuecomment-275570538, or mute the thread https://github.com/notifications/unsubscribe-auth/AAaIASbVOpen8s8wDKQbaF3b2gF_RnFjks5rWU52gaJpZM4Khoa- .

rhyek commented 7 years ago

@seanwash Thank you.