search

seanwlk / warface-crate-manager

Updated version of the crate manager for the Warface Global Operations
GNU General Public License v3.0
8 stars 5 forks source link

Steam login #11

Closed paulyluca closed 4 years ago

paulyluca commented 4 years ago

Hello,

The new version is not remembering the login credentials, like the previous did.

Also, Bitdefender was reporting the executable has a virus. I whitelisted it, of course... :).

Thank you for your great work.

Paul

seanwlk commented 4 years ago

Hi, i ran some test and works on my end. I can only assume that it's because i reworked the structure of creds.json (you still have old one) and didnt take in account that the key "auth_token" was already in use. Try deleting creds.json and logging in with the new version.

PS: What 2 Factor do you have ? steamguard or mail ?

seanwlk commented 4 years ago

Also, Bitdefender was reporting the executable has a virus. I whitelisted it, of course... :).

Ye, nothing i can do about this. It's because of the packaging system with Pyinstaller. You could run the project directly with python source code instead if you dont want to deal with antiviruses.

paulyluca commented 4 years ago

Hi, i ran some test and works on my end. I can only assume that it's because i reworked the structure of creds.json (you still have old one) and didnt take in account that the key "auth_token" was already in use. Try deleting creds.json and logging in with the new version.

PS: What 2 Factor do you have ? steamguard or mail ?

Hy,

Steamguard on my phone.

I tried deleting the creds.json and logg in again. It is still not remembering the credentials. Happens on both, my PC and my laptop.

seanwlk commented 4 years ago

Ok, i see the problem, i messed up during testing phase. Was using an already generated creds.json file. I will push a fix now, meanwhile you can go to Releases: https://github.com/seanwlk/warface-crate-manager/releases I updated the executable files with the patch, Can you download again and try please? Sorry for the incovenience.

harmdhast commented 4 years ago

@seanwlk you should consider saving creds.json in appdata and hashing it's contents especially tokens. You can go as far as hasing them with win session creds but it will require admin rights

seanwlk commented 4 years ago

I actually wanted to obfuscate the file but left it for future update

paulyluca commented 4 years ago

It is OK now.

Thank you.

seanwlk commented 4 years ago

Pushed https://github.com/seanwlk/warface-crate-manager/commit/6f321f494ef791cd2451e0aa65d5010416fcd8f3