seanwu1105 / vscode-qt-for-python

Qt for Python (PySide and PyQt) extension for Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=seanwu.vscode-qt-for-python
MIT License
176 stars 15 forks source link

Plugin compatibility issues with Python 3.7 #292

Closed hrpzcf closed 9 months ago

hrpzcf commented 1 year ago

2023-03-21_172302 2023-03-21_164359

两个截图中的问题是关于 := 运算符和 typing.Literal 的,据我所知这两个都是 Python 3.8+ 可用。 请问作者是否有意修复这些问题以增加对 Python 3.7 的支持?

seanwu1105 commented 1 year ago

Thanks for the report. I will remove the use of these language features in the next release.

seanwu1105 commented 1 year ago

Note that, according to the official docs, Python 3.7 will end its life this June. Thus, we will drop the support at that time and use all language features compatible to 3.8+.

ross-g commented 9 months ago

Could I request this be reconsidered @seanwu1105 ?

While Python 3.7 is now end of life, many applications with embedded Python are still on 3.7. So far as I can see the only incompatibility is the use of the "walrus" operator in scripts/utils/__init__.py which seems trivial enough that 3.7 support could be maintained without development effort.

seanwu1105 commented 9 months ago

Hi @ross-g, I see your point. I will add back 3.7 support then.