search

searceinc / spanner-terraform-example

0 stars 5 forks source link

manage company #5

Closed vigneshsdev closed 3 years ago

vigneshsdev commented 3 years ago

@olavloite , open comments has been resolved. please let me know if we can move this repo to cloud-spanner-ecosystem.

olavloite commented 3 years ago

@olavloite , open comments has been resolved. please let me know if we can move this repo to cloud-spanner-ecosystem.

Thanks for resolving those. I just left a couple of small comments, mostly for error codes and other tiny nits. None of that needs to be considered blocking for moving this repo into cloudspannerecosystem, but please take a look at it (be it at a later moment or before moving).