Batch updates broken for Solr 1.2+

search5 / solrpy

Automatically exported from code.google.com/p/solrpy

Other

40 stars 17 forks source link

Batch updates broken for Solr 1.2+ #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Currently, batch updates are broken in trunk, it's been like that since at
least r6. I don't know which version of Solr the feature was written in
mind with but it doesn't work with Solr 1.2+.

I'm not sure what to do about it as I'm not using it at all. Personally, I
would have nothing against deprecating and removing it, however having it
working again could possibly be an area for contributing to the project.

Original issue reported on code.google.com by ds...@gefira.pl on 30 Aug 2009 at 6:32

GoogleCodeExporter commented 9 years ago

Issue 9 has been merged into this issue.

Original comment by benliles on 14 Sep 2009 at 5:17

GoogleCodeExporter commented 9 years ago

I'd be happy to stick with the add_many/delete_many APIs myself.

Original comment by fdrake on 23 Sep 2009 at 12:31

GoogleCodeExporter commented 9 years ago

I'll try to first come up with some tests and then fix the problem.

Original comment by shywolf9...@gmail.com on 19 Feb 2010 at 9:11

GoogleCodeExporter commented 9 years ago

Okay, I looked at the tests: add_many and delete_many are tested and seem to 
work.

I added some specific tests to update existing documents (adding them and 
readding them afterwards, quickly).

All tests passed. I tested with solr 1.4.0 and 1.3.0 (I couldn't find any 1.2.0 
tarball around, so I skipped that) and 
python2.4. If anyone wishes, testing with other pythons and SOLR versions are 
welcome (but I am not expecting results to 
differ between pythons).

I am closing this bug: feel free to reopen if:

1. Any test fails for you (please report version of SOLR, python, and traceback)
2. You have a case, not among those tested, where there is a failure: please 
report the details though, as it is likely a 
corner situation. If you can provide a test that would be great.

Original comment by shywolf9...@gmail.com on 21 Feb 2010 at 11:00

Changed state: Invalid

GoogleCodeExporter commented 9 years ago

add_many and delete_many work as expected, but start_batch and end_batch are 
broken in trunk. It might be 
better to get rid of those methods all together.

Original comment by team%ink...@gtempaccount.com on 1 Mar 2010 at 10:37

GoogleCodeExporter commented 9 years ago

Ok, I'm reopening the issue.

I'm all for deleting the methods myself, but I don't know if someone uses them 
(but 
they have been broken since r6, so I doubt that).

If anybody needs this, please signal it here or in the group discussion.

Original comment by shywolf9...@gmail.com on 2 Mar 2010 at 4:36

Changed state: New

GoogleCodeExporter commented 9 years ago

As per thread in the group discussion, and since no calls to keep the API alive 
have 
been received, r61 removes the broken API and any reference to it.

Original comment by shywolf9...@gmail.com on 11 Mar 2010 at 9:27

Changed state: Fixed