searchdiscovery / client-jnj-askgs-ga4-dl-spec

An Apollo generated Event Driven Data Layer
1 stars 0 forks source link

Select Search Result #18

Open ajramosSDI opened 1 year ago

ajramosSDI commented 1 year ago

This event should fire whenever a result from the initial search is selected.

Select Search Result.md

mgarzonjnj commented 1 year ago

@ajramosSDI Can you please remove this parameter from this event? "corrected_term": ""

As discussed, we removed the Auto Complete functionality from Search and don't have immediate plans to bring that back.

davisbradleyj commented 1 year ago

@mgarzonjnj

Is there a specific link in the dev site that our team should use for validation?

davisbradleyj commented 1 year ago

@mandyjohnston03 @ajramosSDI

Could you please have a look at the requested change?

mgarzonjnj commented 11 months ago

https://jnjgsportal--predevesp.sandbox.my.site.com/s/search-results?searchterm=leave&geography=United_States&service&language=en_US

This is the link to the search results page with one article available to click.

mandyjohnston03 commented 11 months ago

Event is firing as expected. The following parameters need attention:

'search_slot' is returning a 0 value - should reflect how far down the search result is that is being clicked on 'search_term' is returning the correct term, but with additional characters - "\"payroll\"" - can this be fixed? 'results_count' is returning 20 in every scenario and seems to be hardcoded. This should be dynamic. (is this possible?)

mgarzonjnj commented 11 months ago

'search_slot' is returning a 0 value - is working as expected however starting at 0 instead of 1, this will be fixed 'search_term' is returning the correct term, but with additional characters - ""payroll""

Result_Count - Because of how our search works, in that it indexes 20 results always and only displays another 20 (maxes out at 100) if the user scrolls down, we're unable to make this more dynamic. However, when results are less than 20, I have asked the team to provide that value here.

mgarzonjnj commented 11 months ago

'search_slot' is returning a 0 value - is working as expected however starting at 0 instead of 1, this will be fixed 'search_term' is returning the correct term, but with additional characters - ""payroll""

Result Count will be updated if results are ever less than 20, otherwise, they'll always say 20.

These two have been addressed. Can you please retest?

davisbradleyj commented 11 months ago

Confirming this now passes data layer validation through the GTM debugger:

Image

mandyjohnston03 commented 11 months ago

Passed

Image

davisbradleyj commented 11 months ago

https://jnjgsportal--uat2.sandbox.my.site.com/s/?language=es

mandyjohnston03 commented 11 months ago

Passed in UAT

Image