searchdiscovery / loews-dl-spec-ga4

An Apollo generated Event Driven Data Layer
0 stars 1 forks source link

Accommodation Booking Completed #7

Open braxton-butcher opened 1 year ago

braxton-butcher commented 1 year ago

https://github.com/searchdiscovery/loews-dl-spec-ga4/blob/main/Data%20Layer%20Events/Accommodation%20Booking%20Completed.md

The new Google dataLayer events should fire in all scenarios where the corresponding appEventData data layer event fires.

Please reference the Data Layers Event Mapping document to see the relationship between the two data layers events.

Reference the Data Layers Attribute Mapping document to see how the specific attributes of the old appEventData data layer corresponds to the attributes of the new dataLayer data layer.

Reference the Location ID Mapping document to see how to populate ecommerce.items.item_id and event_data.location_id in the new data layer. Both of these should contain the corresponding hotel code as found in the aforementioned document.

You may also reference the “Attached Notes” section of the event’s specs to determine where and when to fire.

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon 
 Moving back this to "In Progress", the event do not fire when the user clicks on "book now", nothing happen when clicking the CTA

Image

dbokadiya commented 1 year ago

@JH-SDI It will fire on confirmation.

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon

This event keeps failing. Cannot complete a booking:

Image

brendenconcannon commented 1 year ago

@JH-SDI - The only properties that are set up to complete bookings in the preview are the following:

Loews Chicago O'Hare Hotel - configured for Sabre UAT

Loews Miami Beach Hotel - configured for Sabre UAT

Loews Regency New York - configured for Sabre CERTIFICATION ENV (offline)

If you could please try these with other events that have booking events as well.

JH-SDI commented 1 year ago

@brendenconcannon

I've check for these three locations and none of them have availability for making a test booking:

Image Image Image

brendenconcannon commented 1 year ago

@JH-SDI - The Loews team will be opening up periods of availability for testing on these three locations. I will let you know when they have.

dbokadiya commented 1 year ago

@JH-SDI Development is Done, @brendenconcannon @alexsaveljev Kindly help them to Complete booking.

brendenconcannon commented 1 year ago

@JH-SDI - Matthew on the Loews team has opened booking availability for the three locations.

JH-SDI commented 1 year ago

@brendenconcannon

Booking availability remains the same. No availability and same error on checkout page.

Moved back to "to do"

dbokadiya commented 1 year ago

@brendenconcannon Kindly help to test this event.

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon

The properties available for testing still have No availability and we can't complete any order:

Image Image Image

Marked as "to do"

brendenconcannon commented 1 year ago

@JH-SDI - Chicago is open for booking. We are working on opening availability for the other locations as well.

JH-SDI commented 1 year ago

@brendenconcannon

Location has the availability but still cannot complete the booking:

Image

Is there any special rate or room that we need to test? Ideally, we would like to test different locations and rates to validate the event.

Moved back to "To do"

brendenconcannon commented 1 year ago

@braxton-butcher - Chicago availability is back open could you please try testing this again?

acuson commented 1 year ago

Hi @brendenconcannon, I'm coming across the same issue still as @JH-SDI did previously. Moving this ticket back to to-do

Image

brendenconcannon commented 1 year ago

@braxton-butcher @acuson - We were able to get the MyCheck UAT back on the site and can complete test bookings.

Can you please check any location with availability and use the following test CC. Make sure the zip matches in the billing info -

4264-2815-1111-2228 Expiration: 12/23 CV: 123 zip: 11747

JH-SDI commented 1 year ago

@brendenconcannon

Thanks for the update on this event, I have already tested it and it's firing in the expected scenario:

Image

Just a minor improve, the discount should be a number, so if there is no discount, we should send 0

dbokadiya commented 1 year ago

@JH-SDI @brendenconcannon change has been done, kindly review again.

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon

Event is firing as expected:

Image

Moving it to "Done"

JH-SDI commented 1 year ago

@dbokadiya @brendenconcannon

Event is firing as expected:

Image

Marked as "completed"