searchmarkers / mark-my-search

Search keyword highlighter for Firefox and Chromium
https://markmysearch.ator.systems
MIT License
41 stars 3 forks source link

It breaks LinkedIn search page. #134

Open juanmalvarezvaa opened 1 year ago

juanmalvarezvaa commented 1 year ago

When trying to use the extension on a LinkedIn search.. some parts of the search become unresponsive.

ator-dev commented 1 year ago

Thanks for the report!

I wasn't able to reproduce the issue - I tried searching for a few keywords on LinkedIn, and changed pages a few times, but the search was still responsive. Can you describe what can cause the issue please?

juanmalvarezvaa commented 1 year ago

Yes sure! Sorry for the delay.

In the jobs search, having the extensions enabled make changing offers impossible. The URL changed, but it's not rendered on the screen. For example: image There I'm in the first job, and then I click on the second one: image As you can see, nothing changed except the URL.

No error on the Chrome Console.

Thanks!

ator-dev commented 1 year ago

Thank you, the new information is helpful!

I have some good news and some bad news.

Firstly, I don't think the problem as it stands is solvable. Like all search highlighters, Mark My Search has to break up text to insert highlighting elements, which is a problem for some sites. Specifically, I discovered that LinkedIn stores some data in regular elements with display: none - which can't be detected as it would massively impact efficiency - and I suspect this is the reason it breaks. For whatever reason it works well on Firefox.

image

Luckily Mark My Search has a mode built to solve this problem. If you open the extension options (from about:extensions or the popup > Options), uncheck "Use CLASSIC highlighting" and save, you should find that it works better. However, my testing on LinkedIn surfaced some issues with the experimental highlighter:

However, it doesn't break LinkedIn, and it does work (in that highlighting appears and is internally correct, even if it doesn't always get visually updated). I will get back to you with updates on this, as I would love to make the new "PAINT" highlighter available for regular use!

juanmalvarezvaa commented 1 year ago

Ok thanks! That's nice to know, and thanks for the fast answer!