search

searchmarkers / mark-my-search

Search keyword highlighter for Firefox and Chromium
https://markmysearch.ator.systems
European Union Public License 1.2
43 stars 3 forks source link

Do not separate words and reset default options? #153

Open tmpm697 opened 5 months ago

tmpm697 commented 5 months ago

reproduce:

1.  go to: https://daiderd.com/nix-darwin/manual/index.html#opt-nix.linux-builder.systems
2. use left mouse to select `nix.linux-builder`
3. right mouse click and select `Highlight Selection`
4. --> result: mark-my-search separates two: `nix` and `linux-builder`
   but we're expecting one word for searching `nix.linux-builder`

so if we can have option to keep not separate words for searching is better

another issue is that there's no reset options in mark-my-search's settings, so tweaking around and u'll get lost of what are defaults.

ator-dev commented 5 months ago

Thanks for the feedback! I see the problem with the current behaviour. We currently interpret any space or punctuation mark as a word break, but this should probably be changed to any space or punctuation mark followed by 1 or more spaces. I will make a release to address this.

another issue is that there's no reset options in mark-my-search's settings

You can actually see the defaults - in the Options page, every setting has two items, an editable one representing the current value (left), and a greyed-out readonly one representing the default value (right). To restore defaults, you can copy the default value. It's a bit tricky for the text boxes: you have to drag the mouse from one end of the readonly text box, and keep dragging until the whole text is selected, then Ctrl+C and Ctrl+V it into the editable one.

I plan to improve this in the release by adding a per-setting reset button and a reset all button. I will also try to make the saving behaviour more obvious.

ator-dev commented 4 months ago

I will close this issue once I've actually published the changes :slightly_smiling_face: