search

searchspring / magento2-searchspring-feed

SearchSpring's Magento 2 module for data feed generation
http://www.searchspring.com
MIT License
4 stars 5 forks source link

Improve Security #41

Open julesbravo opened 2 years ago

julesbravo commented 2 years ago

We should be using some sort of key for access for security instead of just relying on IP white listing or htaccess. Whatever the M2 way to do this is.

serzhik commented 2 years ago

I'm ready to implement it. But first, check all my pull requests, please

julesbravo commented 2 years ago

Hi @serzhik Which Searchspring account are you working on?

serzhik commented 2 years ago

@julesbravo we use Nextopia now but we need to move to SearchSpring. I'm just looking around and see that this module is implemented not in Magento way. I want to fix the main issues before we can use it.

julesbravo commented 2 years ago

@serzhik What domain name is your account under?

julesbravo commented 2 years ago

@serzhik Adding a key to do this would require also re-architecting this on our indexing server side so that would not be a PR we'd be ready to accept at this time. I'll have our team review the rest of your PRs.

serzhik commented 2 years ago

Yes, of course. I want to prepare the code before it. It will have a switcher in Admin Panel, which behavior to use: "Restriction by IP" or "Using API Key"

julesbravo commented 2 years ago

@serzhik We do not have plans to support an API key on our indexing server side yet at this time. We're actually completely rewriting our M2 module now that pushes the feed to us directly instead of us accessing it from the server.

serzhik commented 2 years ago

@julesbravo I can help you if you need.

julesbravo commented 2 years ago

@serzhik We are working with one of our M2 agency partners on this project already.