searleser97 / cpbooster

Competitive Programming Booster
GNU General Public License v3.0
144 stars 30 forks source link

Implement submit to TLX #106

Closed user202729 closed 2 months ago

user202729 commented 8 months ago

Note:

searleser97 commented 7 months ago

sorry I am just looking at this, Could you clarify why are we changing the format in the session file ?

user202729 commented 7 months ago

If I recalled correctly, the issue is that TLX (and a few other websites) store the session key in JavaScript localStorage, so we need to also backup that.

As for the format of the session file, it might be desirable to maintain some backwards compatibility (?) by storing e.g. the file format version (from now on), and then handle it accordingly. (what do you think?)

searleser97 commented 7 months ago

adding a version entry to the file sounds reasonable, but lets completely deprecate the old one anyways, what I mean is, if the session file they have does not have that "version" entry just ignore it and assume there is no session file. Probably also just print a message in the terminal if it detects they have the old session to warn the user that they will have to login to all their sessions again

searleser97 commented 6 months ago

Hey @user202729, still working on the changes ?

user202729 commented 6 months ago

Alright, all fixed.

What could go wrong? (e.g. user forget password and cpbooster is the only place left where the user is logged in? Can't happen right?)

searleser97 commented 6 months ago

Looks good, but will give it a day before merging, in case you want to still change something