fix: in Nokogiri >= v1.17.0, use SAX::Document#reference

searls / eiwa

A ruby gem that parses the JMDict Japanese-English dictionary

MIT License

7 stars 2 forks source link

fix: in Nokogiri >= v1.17.0, use SAX::Document#reference #11

Open flavorjones opened 3 months ago

flavorjones commented 3 months ago

The #reference callback will be available in Nokogiri v1.17.0. See https://github.com/sparklemotion/nokogiri/pull/3265. That version is not released yet, but this code is backwards-compatible.

This works around the issues reported at:

https://github.com/sparklemotion/nokogiri/issues/1926
https://github.com/sparklemotion/nokogiri/issues/3147

Closes #10.

searls commented 3 months ago

Thanks @flavorjones! Because my app that consumes this is not in active development (and I'm in the "scared to touch it" phase of its lifecycle), I'm going to hold off until this version of the gem releases so I can be sure that I don't break anything

Great job!

flavorjones commented 3 months ago

Totally makes sense. I'm hoping to cut a release later this month.