search

searsandrew / centreforge

WordPress Theme designed for freelance developers with a Bootstrap Base, intended to use child themes for Customer site
0 stars 0 forks source link

pdf-icon shortcode broken #16

Open mread1208 opened 8 years ago

mread1208 commented 8 years ago

I don't think the pdf-icon shortcode is working. The shortcode function isn't receiving the url parameter that we're setting in the TinyMCE button. Along with that, the content is being wrapped inside of a <div>, shouldn't this be wrapped in an <a> tag? Lastly, the fa-pdf-icon-o doesn't appear to be showing. I can go in and fix all this issue, but I'm not sure if this shortcode was built like this on purpose (for older sites that use this theme), or if it needs to be re purposed.

Let me know how I should proceed.

searsandrew commented 8 years ago

Go ahead and keep this assigned to me. I might redo this whole concept with a [fa] or [icon] shortcode and allow people to use whatever they want. This is a very very old piece of code, going back to WC-Core, and it actually loaded a pdf icon image.

searsandrew commented 8 years ago

http://centreforge.us/blog/changelog/webcraft-core-1-0/

mread1208 commented 8 years ago

Wow, yea that is going way back. Yea feel free to do with it what you want, I just didn't want to rework it in case you were using this shortcode on older themes.