search

searsandrew / centreforge

WordPress Theme designed for freelance developers with a Bootstrap Base, intended to use child themes for Customer site
0 stars 0 forks source link

Bootstrap images pull not working #8

Open searsandrew opened 8 years ago

searsandrew commented 8 years ago

The new options that have been added for the 'Bootstrap' images in the Media Uploader do not work as expected.

mread1208 commented 8 years ago

I'm able to add the pull-left pull-right classes from the media uploader and things seem to display fine for me. What is the error exactly?

searsandrew commented 8 years ago

Yeah, ok, so I looked at this. They are doing what we want on the front end (we should add the BS styling to the editor...) but they are duplicating the Right & Left that are already in the Media Object.

mread1208 commented 8 years ago

Ok, let me make sure I'm following.

When I go to add media, in the alignment drop down menu under "Attachment Display Settings", I'm presented 6 options: Left, Bootstrap Left, Center, Right, Bootstrap Right and None. Do we need to remove "Left" and "Right" so that there are only 4 options: Bootstrap Left, Center, Bootstrap Right, and none?

searsandrew commented 8 years ago

Ideally it should just be Left, Center, Right, None -> but using the Bootstrap classes.

mread1208 commented 8 years ago

Gotcha, ok. I can take a look and see if we can't overwrite the default select options that WordPress puts in there. I'm sure we can hook it somehow.