search

searx / searx-docker

Create a searx instance using Docker
GNU Affero General Public License v3.0
404 stars 67 forks source link

Add Permissions-Policy HTTP header to Caddyfile #89

Closed zevlee closed 3 years ago

zevlee commented 3 years ago

The Feature-Policy header was renamed to Permissions-Policy. This PR simply includes this header to the Caddyfile.

See: https://scotthelme.co.uk/goodbye-feature-policy-and-hello-permissions-policy/

unixfox commented 3 years ago

Could you rename your commit name to a more describe name? This is for having a good git commit history in case we need to find this commit later. I would rename it to something like this: "Add Permissions-Policy HTTP header". Feel free to offer something else.

zevlee commented 3 years ago

Just updated the title.

unixfox commented 3 years ago

I'm talking about the commit name not the pull request name.

zevlee commented 3 years ago

Changed the commit name this time. Thank you for your patience.

unixfox commented 3 years ago

Thank you for doing that but could you squash all your commits into one?

unixfox commented 3 years ago

Still 3 commits remaining :)

zevlee commented 3 years ago

I seem to have put myself in an unrecoverable position while learning about how to use git. As such, I will close this pull request and open a new one. Last time, I promise.

unixfox commented 3 years ago

No it's possible to always recover it, you really should do more git learning :).