searxng / searxng-docker

The docker-compose files for setting up a SearXNG instance with docker.
GNU Affero General Public License v3.0
1.01k stars 247 forks source link

Replace Redis with Valkey + reduce logging for containers caddy and redis #230

Closed inetol closed 1 month ago

inetol commented 2 months ago

You know, licensing changes yada yada yada (#3348). This PR replaces Redis by Valkey and cleans up some deprecated, useless or non-defined options in the Docker compose spec. I have already bothered to test if SearXNG works correctly with Valkey, and so far it looks good as they want to maintain interoperability with Redis.

EDIT: Also reduce the logging files for caddy and redis.

unixfox commented 2 months ago

Blocked by https://github.com/searxng/searxng/issues/3348, ongoing discussion.

unixfox commented 2 months ago

We want to keep this PR only for switching to valkey. If you want to improve the docker-compose.yml file please do so in another PR! Thanks

This means that we do not want in this PR changes about dropping capabilities and more.

unixfox commented 1 month ago

Hello, Since this PR is just about migrating to Valkey and not nothing else, I have added back what has been removed: https://github.com/searxng/searxng-docker/pull/230/commits/f888ba3794940a2e3405dc935a3aa31f3fb71c8a

Feel free to create another PR for things like removing the old docker-compose compatibility and such, but we are not going to do these changes in this PR.

unixfox commented 1 month ago

Maybe I have merged this PR a bit too fast but why @inetol you didn't use these docker images instead:

?

inetol commented 1 month ago

I thought I've mentioned this before, the reason for that is because the valkey/valkey image runs under root by default, which is not the case with the current Chainguard ones. I don't know anything about bitnami images, though.

unixfox commented 1 month ago

I thought I've mentioned this before, the reason for that is because the valkey/valkey image runs under root by default, which is not the case with the current Chainguard ones. I don't know anything about bitnami images, though.

Yes, but you can force user ID in docker if that's the only issue.

But my biggest issue is that Chainguard is not well known, and this docker image is not from the official project, so there are always cases for:

rhee876527 commented 1 month ago

@inetol @unixfox

Previous comment by @inetol is not exactly true.

I thought I've mentioned this before, the reason for that is because the valkey/valkey image runs under root by default, which is not the case with the current Chainguard ones. I don't know anything about bitnami images, though.

In my testing of the valkey/valkey:alpine image, it will run as root if redis is not started with command: valkey-server. And I also agree with @unixfox 's comments using the official image is a much better choice.

I think the chainguard image should be substituted with the official valkey image.

inetol commented 1 month ago

Perhaps I was wrong earlier, yes I can confirm what @rhee876527 says: Screenshot

I will open a PR later and see if a smooth migration between images can be done.