search

searxng / searxng-docker

The docker-compose files for setting up a SearXNG instance with docker.
GNU Affero General Public License v3.0
1.21k stars 290 forks source link

Replace with official Valkey image #234

Closed inetol closed 4 months ago

inetol commented 4 months ago

Discussion #230

inetol commented 4 months ago

I can't get the database moved from one image to another, must be an issue with docker-entrypoint.sh as I can't change the user on which the server is running either

unixfox commented 4 months ago

Maybe we could use a new docker volume for that?

inetol commented 4 months ago

WDYM? If we create another volume, Valkey will create a clean RDB losing all the botdetection data (again).

Although, I am of the opinion that docker-compose files is offered as a blueprint and should only be used for the initial installation and not updated from remote (at least not without checking the changes and taking the plunge if there is a big change). Images or config changes happen and there is not always the possibility of a clean migration without manual intervention, and more so in different configurations on different machines in different container managers.

unixfox commented 4 months ago

WDYM? If we create another volume, Valkey will create a clean RDB losing all the botdetection data (again).

It's ok, if we wait too much time it's going to be an issue. But there has been only one week since the last change about valkey.

Although, I am of the opinion that docker-compose files is offered as a blueprint and should only be used for the initial installation and not updated from remote (at least not without checking the changes and taking the plunge if there is a big change). Images or config changes happen and there is not always the possibility of a clean migration without manual intervention, and more so in different configurations on different machines in different container managers.

I would like to keep updates as smooth as possible when there is a possibility to do it.

inetol commented 4 months ago

OK, I've been a bit busy these days hence my delay.

Basically this PR is ready to go unless you want to rename the volume so that there are no conflicts with people who update the template in a rough way, in that case I don't know if valkey-data2 would be good enough?

unixfox commented 4 months ago

Good for me yes :)