seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Bugfix: Fix tests checking retired functionality #531

Closed natalynyu closed 2 years ago

natalynyu commented 2 years ago

These tests were previously failing, because the tests were calculating the current academic year as 2023, while these tests are trying to retire course instances from 2022. Since we're not allowed to retire instances of the past, the current academic year has been stubbed to 2022 so that the tests no longer fail as the real academic year changes.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #530

codecov[bot] commented 2 years ago

Codecov Report

Merging #531 (3e4fe28) into develop (e6a9ab8) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #531   +/-   ##
========================================
  Coverage    96.11%   96.11%           
========================================
  Files          176      176           
  Lines         3703     3703           
  Branches       432      432           
========================================
  Hits          3559     3559           
  Misses          68       68           
  Partials        76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8017311...3e4fe28. Read the comment docs.