seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Fix Schedule Display - Extend end time to 10pm #544

Closed natalynyu closed 2 years ago

natalynyu commented 2 years ago

This PR updates the schedule such that the end time is extended from 8pm to 10pm. According to our users, the latest end time for a course is 9:30pm. For now, we will hardcode the end time value as 10pm, but we may dynamically update the end time in the future.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #535

codecov[bot] commented 2 years ago

Codecov Report

Merging #544 (89fd8de) into develop (a15a0c9) will increase coverage by 0.04%. The diff coverage is 100.00%.

:exclamation: Current head 89fd8de differs from pull request most recent head 0df0599. Consider uploading reports for the commit 0df0599 to get more accurate results

@@             Coverage Diff             @@
##           develop     #544      +/-   ##
===========================================
+ Coverage    96.13%   96.18%   +0.04%     
===========================================
  Files          178      179       +1     
  Lines         3724     3746      +22     
  Branches       435      440       +5     
===========================================
+ Hits          3580     3603      +23     
  Misses          68       68              
+ Partials        76       75       -1     
Impacted Files Coverage Δ
...rc/client/components/pages/Courses/CoursesPage.tsx 92.46% <100.00%> (-0.15%) :arrow_down:
...rc/client/components/pages/Faculty/FacultyPage.tsx 100.00% <100.00%> (ø)
.../client/components/pages/Schedule/SchedulePage.tsx 95.65% <100.00%> (ø)
.../client/components/pages/Schedule/ScheduleView.tsx 96.87% <100.00%> (+0.72%) :arrow_up:
...ents/pages/Schedule/blocks/CourseListingButton.tsx 100.00% <100.00%> (ø)
.../components/pages/Schedule/blocks/SessionBlock.tsx 100.00% <100.00%> (ø)
...ient/components/pages/utils/academicYearOptions.ts 100.00% <100.00%> (ø)
...t/components/pages/Faculty/FacultyAbsenceModal.tsx 100.00% <0.00%> (+2.43%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.