Closed Urjikoo closed 1 year ago
Merging #587 (c1c9d14) into develop (07548c9) will decrease coverage by
0.26%
. The diff coverage is91.57%
.
@@ Coverage Diff @@
## develop #587 +/- ##
===========================================
- Coverage 95.70% 95.44% -0.27%
===========================================
Files 191 191
Lines 4777 4632 -145
Branches 631 581 -50
===========================================
- Hits 4572 4421 -151
- Misses 102 104 +2
- Partials 103 107 +4
Impacted Files | Coverage Δ | |
---|---|---|
...rc/client/components/pages/Courses/CoursesPage.tsx | 92.03% <0.00%> (-0.66%) |
:arrow_down: |
...t/components/pages/Faculty/FacultyAbsenceModal.tsx | 78.84% <33.33%> (-6.87%) |
:arrow_down: |
.../client/components/pages/Schedule/ScheduleView.tsx | 97.43% <87.50%> (+0.56%) |
:arrow_up: |
src/server/faculty/faculty.controller.ts | 97.29% <90.90%> (-0.91%) |
:arrow_down: |
...rc/client/components/pages/Faculty/FacultyPage.tsx | 94.44% <92.59%> (-3.97%) |
:arrow_down: |
src/server/faculty/faculty.service.ts | 97.22% <96.66%> (-0.08%) |
:arrow_down: |
...lient/components/pages/Courses/EnrollmentModal.tsx | 88.73% <100.00%> (-4.26%) |
:arrow_down: |
...lient/components/pages/Courses/InstructorModal.tsx | 90.58% <100.00%> (-1.27%) |
:arrow_down: |
...c/client/components/pages/Courses/MeetingModal.tsx | 92.85% <100.00%> (-3.26%) |
:arrow_down: |
...c/client/components/pages/Courses/OfferedModal.tsx | 85.71% <100.00%> (-5.20%) |
:arrow_down: |
... and 27 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Drop down and text input filters were implemented on Room Admin table. Two drop down filters to filter campus and building as well as text input filters were added to filter table content based on user selection. The capacity filter will give a user room options with minimum capacity the user entered: eg. user entered 35, the table will be filtered to show rooms that has minimum 35 capacity and above. Tests were added to test the table content is unfiltered until user select the options and then if it's filtered and show the correct information after selection.
Types of changes
Checklist:
eslint
on the codePriority:
Related Issues:
Fixes #569