Closed Urjikoo closed 1 year ago
Merging #588 (6600c3e) into develop (faa5e03) will decrease coverage by
0.34%
. The diff coverage is93.22%
.:exclamation: Current head 6600c3e differs from pull request most recent head e23ad10. Consider uploading reports for the commit e23ad10 to get more accurate results
@@ Coverage Diff @@
## develop #588 +/- ##
===========================================
- Coverage 95.77% 95.42% -0.35%
===========================================
Files 187 191 +4
Lines 4069 4418 +349
Branches 475 528 +53
===========================================
+ Hits 3897 4216 +319
- Misses 87 98 +11
- Partials 85 104 +19
Impacted Files | Coverage Δ | |
---|---|---|
src/client/context/MetadataContext.ts | 82.60% <66.66%> (-17.40%) |
:arrow_down: |
src/server/location/location.controller.ts | 90.00% <81.81%> (-10.00%) |
:arrow_down: |
...lient/components/pages/RoomAdmin/EditRoomModal.tsx | 89.55% <89.55%> (ø) |
|
...rc/client/components/pages/Faculty/FacultyPage.tsx | 94.44% <92.59%> (-5.56%) |
:arrow_down: |
...ent/components/pages/RoomAdmin/CreateRoomModal.tsx | 93.00% <93.00%> (ø) |
|
src/server/location/location.service.ts | 96.55% <93.93%> (-3.45%) |
:arrow_down: |
src/client/api/rooms.ts | 100.00% <100.00%> (ø) |
|
...t/components/pages/Faculty/FacultyAbsenceModal.tsx | 78.84% <100.00%> (-1.93%) |
:arrow_down: |
.../components/pages/Faculty/FacultyScheduleTable.tsx | 100.00% <100.00%> (ø) |
|
...rc/client/components/pages/RoomAdmin/RoomAdmin.tsx | 100.00% <100.00%> (ø) |
|
... and 5 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
course prefix buttons and dropdown filters style implemented on schedule page. The dropdown filters spacing was cleaned up and position was adjusted to put both filters on the same line. Course filter buttons spacing were added to separate the buttons. Additionally, the buttons background color implemented to show their state: when the button is clicked, the button's background will be removed while it's still fading the session block but the font and the border still shows the prefix color for color coordination consistency.
Types of changes
Checklist:
eslint
on the codePriority:
Related Issues:
Fixes #576