Checkout version before building

[jonseitz]

This added step will check out the latest version of our code, as determined in the pre-publish stage. We need this because the checkout action will, by default, run on the "main" branch, and we want to be sure that we're building off of whatever code was just merged by using the incremented version tag.

Note that we're building both the _QA and _PROD static bundles off of the same code, but parsing different environment variable to set, among other things, the client and server URLs. This is different from our docker images, where the :qa and :stable tags track the develop and main branches, respectively. This is kind of confusing and may change in the future, but for now I suggest we leave it as is.

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] I have run eslint on the code
• [ ] I have added JSDoc for all of my code (where applicable)
• [ ] I have added tests to cover my changes.

Priority:

• [x] Normal
• [ ] High

Related Issues:

Fixes #___

[codecov[bot]]

Codecov Report

Merging #594 (75bbfb6) into develop (fb19535) will increase coverage by 0.01%. The diff coverage is 89.65%.

:exclamation: Current head 75bbfb6 differs from pull request most recent head 8fabc9b. Consider uploading reports for the commit 8fabc9b to get more accurate results

@@             Coverage Diff             @@
##           develop     #594      +/-   ##
===========================================
+ Coverage    95.26%   95.27%   +0.01%     
===========================================
  Files          191      191              
  Lines         4453     4470      +17     
  Branches       536      539       +3     
===========================================
+ Hits          4242     4259      +17     
+ Misses         101      100       -1     
- Partials       110      111       +1     

Impacted Files	Coverage Δ
...c/client/components/pages/Courses/MeetingModal.tsx	92.35% <89.65%> (-0.51%)	:arrow_down:
src/server/location/location.service.ts	96.55% <0.00%> (+3.44%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[farassadek]

This looks good and it can be merged. Though I noticed this warning

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This warning about the statement: echo "::set-output name=result::$PACKAGE_NAME" This could be fixed by replacing the above statement with: echo "result=$PACKAGE_NAME" >> $GITHUB_OUTPUT

The same thing with: echo "::set-output name=result::$VERSION_TAG" => echo "result=$VERSION_TAG" >> $GITHUB_OUTPUT and echo "::set-output name=result::$DOCKER_TAG" => echo "result=$DOCKER_TAG" >> $GITHUB_OUTPUT

[jonseitz]

Thanks Faras! I'm going to open a separate issue for updating the set-output commands, since we have some time before it becomes an error, and I'd like to do some extra testing when we're out of the pre-launch crunch.