seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Move loading spinner to modal body #611

Closed rmainwork closed 1 year ago

rmainwork commented 1 year ago

This PR moves the loading spinner from the modal footer...

image

.... and into the modal body image

this fixes a UI bug where saving meetings causes the modal footer (and buttons) to stretch vertically. It also hides the modal content when saving, which is how other modals behave, so it also provides some consistency.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #595

codecov[bot] commented 1 year ago

Codecov Report

Merging #611 (7f0ea34) into develop (fe2b990) will decrease coverage by 0.04%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #611      +/-   ##
===========================================
- Coverage    95.28%   95.23%   -0.05%     
===========================================
  Files          191      191              
  Lines         4472     4470       -2     
  Branches       540      539       -1     
===========================================
- Hits          4261     4257       -4     
- Misses         100      101       +1     
- Partials       111      112       +1     
Impacted Files Coverage Δ
...c/client/components/pages/Courses/MeetingModal.tsx 92.35% <100.00%> (ø)
src/server/location/location.service.ts 93.10% <0.00%> (-3.45%) :arrow_down:
...rc/client/components/pages/Courses/tableFields.tsx 92.66% <0.00%> (-0.14%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more