Closed rmainwork closed 1 year ago
Merging #611 (7f0ea34) into develop (fe2b990) will decrease coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #611 +/- ##
===========================================
- Coverage 95.28% 95.23% -0.05%
===========================================
Files 191 191
Lines 4472 4470 -2
Branches 540 539 -1
===========================================
- Hits 4261 4257 -4
- Misses 100 101 +1
- Partials 111 112 +1
Impacted Files | Coverage Δ | |
---|---|---|
...c/client/components/pages/Courses/MeetingModal.tsx | 92.35% <100.00%> (ø) |
|
src/server/location/location.service.ts | 93.10% <0.00%> (-3.45%) |
:arrow_down: |
...rc/client/components/pages/Courses/tableFields.tsx | 92.66% <0.00%> (-0.14%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR moves the loading spinner from the modal footer...
.... and into the modal body![image](https://user-images.githubusercontent.com/50675045/211392736-99d45322-5aad-4d88-a99d-97518b7f04a6.png)
this fixes a UI bug where saving meetings causes the modal footer (and buttons) to stretch vertically. It also hides the modal content when saving, which is how other modals behave, so it also provides some consistency.
Types of changes
Checklist:
eslint
on the codePriority:
Related Issues:
Fixes #595