seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Fix Course Ordering in Multi Year Plan and Course Admin tables #621

Closed natalynyu closed 1 year ago

natalynyu commented 1 year ago

This PR updates the ordering of courses so that instead of ordering by catalogNumber, we are ordering by the integer portion of the course number and the alpha part of the course number so that CS 50 appears before CS 100, for instance.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #616

codecov[bot] commented 1 year ago

Codecov Report

Merging #621 (d69155b) into develop (d5e2faf) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #621   +/-   ##
========================================
  Coverage    95.25%   95.26%           
========================================
  Files          191      192    +1     
  Lines         4472     4480    +8     
  Branches       540      543    +3     
========================================
+ Hits          4260     4268    +8     
  Misses         100      100           
  Partials       112      112           
Impacted Files Coverage Δ
...rc/client/components/pages/Courses/CoursesPage.tsx 92.03% <ø> (ø)
...ent/components/pages/RoomSchedule/RoomSchedule.tsx 85.36% <ø> (ø)
src/server/course/course.service.ts 100.00% <ø> (ø)
...rc/server/courseInstance/courseInstance.service.ts 96.87% <ø> (ø)
src/server/metadata/metadata.controller.ts 100.00% <ø> (ø)
src/client/components/general/flex/RightMenu.tsx 100.00% <100.00%> (ø)
src/client/components/general/flex/index.ts 100.00% <100.00%> (ø)
...c/client/components/pages/Courses/MeetingModal.tsx 92.35% <100.00%> (ø)
...rc/client/components/pages/Faculty/FacultyPage.tsx 94.44% <100.00%> (ø)
src/client/components/layout/AppRouter.tsx 82.60% <0.00%> (-3.76%) :arrow_down:
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more