seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Create absence records on creation of faculty member #623

Closed rmainwork closed 1 year ago

rmainwork commented 1 year ago

Creating a new faculty member does not currently populate the absence table. This in turn leads to a white screen of death when trying to access the faculty page.

This PR addresses this issue by adding a Subscriber that listens for the creation of Faculty and adds the appropriate Absence records to match.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #620

codecov[bot] commented 1 year ago

Codecov Report

Merging #623 (40f4a28) into develop (a0f7aa5) will increase coverage by 0.00%. The diff coverage is 87.50%.

:exclamation: Current head 40f4a28 differs from pull request most recent head 6962b1f. Consider uploading reports for the commit 6962b1f to get more accurate results

@@           Coverage Diff            @@
##           develop     #623   +/-   ##
========================================
  Coverage    95.24%   95.24%           
========================================
  Files          192      192           
  Lines         4475     4480    +5     
  Branches       541      541           
========================================
+ Hits          4262     4267    +5     
  Misses         100      100           
  Partials       113      113           
Impacted Files Coverage Δ
src/client/components/layout/AppHeader.tsx 92.00% <ø> (ø)
src/client/components/layout/AppRouter.tsx 82.60% <0.00%> (ø)
.../components/pages/Faculty/FacultyScheduleTable.tsx 100.00% <ø> (ø)
src/client/components/pages/FacultyAdmin.tsx 100.00% <ø> (ø)
.../client/components/pages/Schedule/ScheduleView.tsx 94.87% <ø> (ø)
src/server/course/course.service.ts 100.00% <ø> (ø)
src/server/faculty/faculty.controller.ts 97.46% <100.00%> (+0.17%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

rmainwork commented 1 year ago

Yay, thanks!