seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Refactor faculty creation to use subscribers for absence creation #625

Open rmainwork opened 1 year ago

rmainwork commented 1 year ago

Description

When creating new faculty members, the absences are (currently) created in the controller. This should probably be moved to a subscriber to be more in-keeping with the TypeORM way of doing things as well as providing a better guarantee that creating a new faculty member will always create the appropriate absences (rather than having to rely on the controller doing it correctly for us)