seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

column width adjusted at MeetingGrid component on courses page. #630

Closed Urjikoo closed 1 year ago

Urjikoo commented 1 year ago

parent added to meetingGrid component to adjust the width and margin and width added to meetingGridSection and meetingGrid components.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #502

Urjikoo commented 1 year ago

This PR addresses the space issue in meeting column on courses page as well as the layout of contents rendered in the column when the site accessed on desktop screen. To address the space issue, i created a parent for meetingGrid and MeetingGridSection components and added width and margin to minimize the spacing without narrowing(shrinking) the MeetingGrid and MeetingGridSection content.

codecov[bot] commented 1 year ago

Codecov Report

Merging #630 (97957ca) into develop (2218577) will increase coverage by 0.12%. The diff coverage is 98.50%.

@@             Coverage Diff             @@
##           develop     #630      +/-   ##
===========================================
+ Coverage    95.54%   95.66%   +0.12%     
===========================================
  Files          191      192       +1     
  Lines         4580     4823     +243     
  Branches       570      618      +48     
===========================================
+ Hits          4376     4614     +238     
- Misses          98      101       +3     
- Partials       106      108       +2     
Impacted Files Coverage Δ
...rc/client/components/pages/Courses/modalFields.tsx 100.00% <ø> (ø)
...rc/client/components/pages/Courses/tableFields.tsx 93.88% <0.00%> (-0.53%) :arrow_down:
src/common/constants/columns.ts 100.00% <ø> (ø)
.../components/pages/Faculty/FacultyScheduleTable.tsx 100.00% <100.00%> (ø)
...ent/components/pages/RoomSchedule/RoomSchedule.tsx 86.04% <100.00%> (+1.04%) :arrow_up:
.../client/components/pages/Schedule/SchedulePage.tsx 97.10% <100.00%> (-1.07%) :arrow_down:
src/server/course/course.controller.ts 93.75% <0.00%> (-6.25%) :arrow_down:
src/client/components/layout/AppRouter.tsx 82.60% <0.00%> (-3.76%) :arrow_down:
...rc/server/courseInstance/courseInstance.service.ts 95.55% <0.00%> (-1.32%) :arrow_down:
... and 19 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more