seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Add version tag via hardcoded .env variable #631

Closed natalynyu closed 1 year ago

natalynyu commented 1 year ago

This PR adds a Footer that contains the app version number via a (currently) hardcoded .env value. The .env-example file was updated to include the APP_VERSION variable. In the future, the version number will come from Github Actions as opposed to a hardcoded value.

image

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #618

codecov[bot] commented 1 year ago

Codecov Report

Merging #631 (1026ee5) into develop (300b645) will decrease coverage by 0.04%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #631      +/-   ##
===========================================
- Coverage    95.21%   95.17%   -0.04%     
===========================================
  Files          192      192              
  Lines         4553     4519      -34     
  Branches       555      559       +4     
===========================================
- Hits          4335     4301      -34     
+ Misses         102      101       -1     
- Partials       116      117       +1     
Impacted Files Coverage Δ
src/server/course/course.service.ts 100.00% <ø> (ø)
...rc/server/courseInstance/courseInstance.service.ts 96.87% <ø> (+1.52%) :arrow_up:
src/client/components/App.tsx 96.66% <100.00%> (+0.11%) :arrow_up:
src/server/faculty/faculty.controller.ts 97.46% <100.00%> (-1.68%) :arrow_down:
...rc/client/components/pages/Courses/tableFields.tsx 93.79% <0.00%> (+1.00%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

natalynyu commented 1 year ago

Looks great! Sorry this got held up by the plague

Thanks Jonathan! No worries at all - hope you are feeling better!