Improve Faculty Filters

[natalynyu]

The users requested that we update the faculty filters to match the current course filters on the Courses Page such that the faculty filter values remain the same after navigating to different academic years. Previously, the filter values were cleared when a new academic year was selected, and now the filter values are preserved even after navigating to a new year. This was achieved by moving the filtering logic up a level to the FacultyPage and passing down the filtered faculty rather than having the filtering logic on the table itself. This made it possible to preserve the filter values rather than having them reset every time a new year was selected.

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] I have run eslint on the code
• [x] I have added JSDoc for all of my code (where applicable)
• [x] I have added tests to cover my changes.

Priority:

• [x] Normal
• [ ] High

Related Issues:

Fixes #634

[codecov[bot]]

Codecov Report

Merging #639 (7295f6b) into develop (8454770) will increase coverage by 0.08%. The diff coverage is 94.50%.

:exclamation: Current head 7295f6b differs from pull request most recent head 4318593. Consider uploading reports for the commit 4318593 to get more accurate results

@@             Coverage Diff             @@
##           develop     #639      +/-   ##
===========================================
+ Coverage    95.11%   95.20%   +0.08%     
===========================================
  Files          193      194       +1     
  Lines         4487     4506      +19     
  Branches       544      543       -1     
===========================================
+ Hits          4268     4290      +22     
+ Misses         102      100       -2     
+ Partials       117      116       -1     

Impacted Files	Coverage Δ
src/client/components/pages/CourseAdmin.tsx	100.00% <ø> (ø)
...ent/components/pages/RoomAdmin/CreateRoomModal.tsx	93.00% <ø> (ø)
...lient/components/pages/RoomAdmin/EditRoomModal.tsx	89.55% <ø> (ø)
src/server/course/course.service.ts	100.00% <ø> (ø)
src/server/course/course.controller.ts	90.38% <40.00%> (+2.62%)	:arrow_up:
...rc/client/components/pages/Faculty/FacultyPage.tsx	93.80% <93.33%> (+1.41%)	:arrow_up:
src/client/classes/Validation.ts	100.00% <100.00%> (ø)
src/client/classes/index.ts	100.00% <100.00%> (ø)
...rc/client/components/pages/Courses/CourseModal.tsx	87.37% <100.00%> (+0.64%)	:arrow_up:
...lient/components/pages/Courses/EnrollmentModal.tsx	88.05% <100.00%> (ø)
... and 11 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more