Closed Urjikoo closed 1 year ago
This PR address the scrollbar width on schedule page when the page is accessed on Microsoft edge and Firefox browsers. Initially both horizontal and vertical scrollbars appeared on sessionblocks on schedule page table, so to remove it, i've adjusted the sessionblock min width to remove horizontal scrollbar and did shrunk vertical scrollbar.
Merging #643 (ae69a21) into develop (300b645) will decrease coverage by
0.14%
. The diff coverage is90.99%
.:exclamation: Current head ae69a21 differs from pull request most recent head 9d2ccd2. Consider uploading reports for the commit 9d2ccd2 to get more accurate results
@@ Coverage Diff @@
## develop #643 +/- ##
===========================================
- Coverage 95.21% 95.07% -0.14%
===========================================
Files 192 194 +2
Lines 4553 4511 -42
Branches 555 545 -10
===========================================
- Hits 4335 4289 -46
- Misses 102 104 +2
- Partials 116 118 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/client/components/pages/CourseAdmin.tsx | 100.00% <ø> (ø) |
|
...rc/client/components/pages/Courses/tableFields.tsx | 92.79% <0.00%> (ø) |
|
...ent/components/pages/RoomAdmin/CreateRoomModal.tsx | 93.00% <ø> (ø) |
|
...lient/components/pages/RoomAdmin/EditRoomModal.tsx | 89.55% <ø> (ø) |
|
src/server/course/course.service.ts | 100.00% <ø> (ø) |
|
...rc/server/courseInstance/courseInstance.service.ts | 96.87% <ø> (+1.52%) |
:arrow_up: |
src/server/course/course.controller.ts | 90.38% <40.00%> (+2.62%) |
:arrow_up: |
src/server/semester/semester.service.ts | 80.61% <50.00%> (-3.26%) |
:arrow_down: |
...rc/client/components/pages/Faculty/FacultyPage.tsx | 93.80% <93.33%> (+1.41%) |
:arrow_up: |
src/client/classes/Validation.ts | 100.00% <100.00%> (ø) |
|
... and 16 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Types of changes
Checklist:
eslint
on the codePriority:
Related Issues:
Fixes #633