Closed rmainwork closed 1 year ago
Merging #644 (b138562) into develop (79e9f60) will decrease coverage by
0.13%
. The diff coverage is86.36%
.:exclamation: Current head b138562 differs from pull request most recent head c73bfdd. Consider uploading reports for the commit c73bfdd to get more accurate results
@@ Coverage Diff @@
## develop #644 +/- ##
===========================================
- Coverage 95.20% 95.07% -0.13%
===========================================
Files 194 194
Lines 4505 4511 +6
Branches 545 545
===========================================
Hits 4289 4289
- Misses 100 104 +4
- Partials 116 118 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/server/semester/semester.service.ts | 80.61% <50.00%> (-3.26%) |
:arrow_down: |
...rc/client/components/pages/Faculty/FacultyPage.tsx | 93.80% <93.33%> (+1.41%) |
:arrow_up: |
.../components/pages/Faculty/FacultyScheduleTable.tsx | 100.00% <100.00%> (ø) |
|
src/server/location/location.service.ts | 93.10% <0.00%> (-3.45%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR builds on the work in #546 and cascades these changes into the new semester upon creation. This means that:
ABSENCE_TYPE.NO_LONGER_ACTIVE
will cascade into the newly created semester as suchABSENCE_TYPE.PRESENT
in the newly created semester.Types of changes
Checklist:
eslint
on the codePriority:
Related Issues:
Fixes #534