seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Four-Year Plan: Hide Retired Courses #646

Open jonseitz opened 1 year ago

jonseitz commented 1 year ago

Per a note from Patick Ulrich, it seems the Four-Year plan is showing retired courses in the list. Those course obviously don't have any instances associated with them, so there's no additional data and they're just cluttering up the interface.

I think we'll need to add an additional WHERE condition in CourseInstanceService#getMultiYearPlan to only get courses that are not retired for the given semester range. That might be complicated only by the fact that the MultiYearPlanInstanceView we're using doesn't include the offered field that would be used to check that. We may need to update the view, or join with the original CourseInstance entity, to add that field to the query.