seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Incorporate Same As Logic to Update Multi Year Plan and Schedule Table Displays #652

Closed natalynyu closed 1 year ago

natalynyu commented 1 year ago

This PR contains 3 migrations. It updates the server logic such that the Multi Year Plan table will show the instructors of the course's parent if there is one. It also updates the Schedule such that the meeting information (day, time, and room information) of the parent, if there is one, is displayed.

A separate PR will be opened to update the display of the Faculty table to show the same as relationship.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #642

codecov[bot] commented 1 year ago

Codecov Report

Merging #652 (6a4596b) into develop (9eedd5f) will increase coverage by 0.06%. The diff coverage is 100.00%.

:exclamation: Current head 6a4596b differs from pull request most recent head 5575662. Consider uploading reports for the commit 5575662 to get more accurate results

@@             Coverage Diff             @@
##           develop     #652      +/-   ##
===========================================
+ Coverage    94.13%   94.20%   +0.06%     
===========================================
  Files          194      194              
  Lines         4587     4588       +1     
  Branches       561      564       +3     
===========================================
+ Hits          4318     4322       +4     
  Misses         149      149              
+ Partials       120      117       -3     
Impacted Files Coverage Δ
src/client/components/pages/CourseAdmin.tsx 100.00% <ø> (ø)
...t/components/pages/Courses/CourseInstanceTable.tsx 100.00% <ø> (ø)
.../components/pages/Faculty/FacultyScheduleTable.tsx 100.00% <ø> (ø)
src/client/components/pages/FacultyAdmin.tsx 100.00% <ø> (ø)
src/client/components/pages/MultiYearPlan.tsx 100.00% <ø> (ø)
...rc/client/components/pages/RoomAdmin/RoomAdmin.tsx 100.00% <ø> (ø)
...rc/server/courseInstance/courseInstance.service.ts 96.87% <ø> (ø)
...nt/components/pages/Courses/RoomSelectionTable.tsx 100.00% <100.00%> (ø)
.../client/components/pages/Schedule/ScheduleView.tsx 95.23% <100.00%> (+0.36%) :arrow_up:
src/server/log/log.service.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more