seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Feature/345 implement table scrolling while table headers stick #653

Closed Urjikoo closed 1 year ago

Urjikoo commented 1 year ago

Describe your changes

Mark-one prop called 'isSticky' added to TableHead to make the table head position sticky. To make the information still visible on the top of the table, tableHead defaults to isSticky' prop when the table is scrolled.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #345

codecov[bot] commented 1 year ago

Codecov Report

Merging #653 (2b04e74) into develop (7295f6b) will decrease coverage by 0.05%. The diff coverage is 94.44%.

@@             Coverage Diff             @@
##           develop     #653      +/-   ##
===========================================
- Coverage    95.20%   95.16%   -0.05%     
===========================================
  Files          194      194              
  Lines         4506     4506              
  Branches       543      543              
===========================================
- Hits          4290     4288       -2     
- Misses         100      101       +1     
- Partials       116      117       +1     
Impacted Files Coverage Δ
src/client/components/pages/CourseAdmin.tsx 100.00% <ø> (ø)
...t/components/pages/Courses/CourseInstanceTable.tsx 100.00% <ø> (ø)
src/client/components/pages/FacultyAdmin.tsx 100.00% <ø> (ø)
src/client/components/pages/MultiYearPlan.tsx 100.00% <ø> (ø)
...rc/client/components/pages/RoomAdmin/RoomAdmin.tsx 100.00% <ø> (ø)
...rc/client/components/pages/Faculty/FacultyPage.tsx 93.80% <93.33%> (ø)
.../components/pages/Faculty/FacultyScheduleTable.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more