seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Update display of related courses in Faculty Schedule #662

Closed natalynyu closed 1 year ago

natalynyu commented 1 year ago

This PR updates the display of the Faculty Schedule to include the courses that are related via the "same as" relationship set in the Course entity. This is considered a breaking change, because it includes a migration to add the sameAs column to the ScheduleBlockView so that we can get access to this relationship.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #642

codecov[bot] commented 1 year ago

Codecov Report

Merging #662 (8096d72) into develop (5575662) will increase coverage by 0.03%. The diff coverage is 95.23%.

:exclamation: Current head 8096d72 differs from pull request most recent head 85cad21. Consider uploading reports for the commit 85cad21 to get more accurate results

@@             Coverage Diff             @@
##           develop     #662      +/-   ##
===========================================
+ Coverage    94.16%   94.19%   +0.03%     
===========================================
  Files          194      195       +1     
  Lines         4590     4602      +12     
  Branches       564      567       +3     
===========================================
+ Hits          4322     4335      +13     
+ Misses         150      149       -1     
  Partials       118      118              
Impacted Files Coverage Δ
src/client/components/pages/CourseAdmin.tsx 100.00% <ø> (ø)
...t/components/pages/Courses/CourseInstanceTable.tsx 100.00% <ø> (ø)
src/client/components/pages/FacultyAdmin.tsx 100.00% <ø> (ø)
src/client/components/pages/MultiYearPlan.tsx 100.00% <ø> (ø)
...rc/client/components/pages/RoomAdmin/RoomAdmin.tsx 100.00% <ø> (ø)
...lient/components/pages/utils/deduplicateCourses.ts 90.90% <90.90%> (ø)
src/client/components/App.tsx 96.87% <100.00%> (+0.20%) :arrow_up:
...nt/components/pages/Courses/RoomSelectionTable.tsx 100.00% <100.00%> (ø)
.../components/pages/Faculty/FacultyScheduleTable.tsx 100.00% <100.00%> (ø)
src/server/log/log.service.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more