seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Feature/656 course report add same as field to spreadsheet #664

Closed Urjikoo closed 1 year ago

Urjikoo commented 1 year ago

Describe your changes

This PR adds a field to the course report download spread sheet. When a user clicks on Download Course Report button, whether the sameAs selected in the customized view menu or not, sameAs field appears next to notes column with sameAs information.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #656

codecov[bot] commented 1 year ago

Codecov Report

Merging #664 (90883fd) into develop (23888d2) will increase coverage by 0.06%. The diff coverage is 95.45%.

:exclamation: Current head 90883fd differs from pull request most recent head 32b1ffa. Consider uploading reports for the commit 32b1ffa to get more accurate results

@@             Coverage Diff             @@
##           develop     #664      +/-   ##
===========================================
+ Coverage    94.13%   94.19%   +0.06%     
===========================================
  Files          194      195       +1     
  Lines         4587     4602      +15     
  Branches       561      567       +6     
===========================================
+ Hits          4318     4335      +17     
  Misses         149      149              
+ Partials       120      118       -2     
Impacted Files Coverage Δ
...rc/server/courseInstance/courseInstance.service.ts 96.87% <ø> (ø)
src/server/report/report.service.ts 93.24% <ø> (ø)
...lient/components/pages/utils/deduplicateCourses.ts 90.90% <90.90%> (ø)
...nt/components/pages/Courses/RoomSelectionTable.tsx 100.00% <100.00%> (ø)
.../components/pages/Faculty/FacultyScheduleTable.tsx 100.00% <100.00%> (ø)
.../client/components/pages/Schedule/ScheduleView.tsx 95.23% <100.00%> (+0.36%) :arrow_up:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more