seas-computing / course-planner

SEAS Course Planning Application. JSDoc Docs at: https://seas-computing.github.io/course-planner/
0 stars 1 forks source link

Bugfix/move styled footer component to resolve build issue #667

Closed Urjikoo closed 1 year ago

Urjikoo commented 1 year ago

Initially the new styled footer component CustomFooter was initialized in app component because of that the build on github was failing. Therefore it's now initialized right before app component.

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #___

codecov[bot] commented 1 year ago

Codecov Report

Merging #667 (2a813ca) into develop (8096d72) will decrease coverage by 0.04%. The diff coverage is 95.00%.

:exclamation: Current head 2a813ca differs from pull request most recent head e4ea2b4. Consider uploading reports for the commit e4ea2b4 to get more accurate results

@@             Coverage Diff             @@
##           develop     #667      +/-   ##
===========================================
- Coverage    94.19%   94.15%   -0.04%     
===========================================
  Files          195      196       +1     
  Lines         4602     4606       +4     
  Branches       567      567              
===========================================
+ Hits          4335     4337       +2     
- Misses         149      150       +1     
- Partials       118      119       +1     
Impacted Files Coverage Δ
...lient/components/pages/utils/deduplicateCourses.ts 90.90% <90.90%> (ø)
src/client/components/App.tsx 96.77% <100.00%> (-0.11%) :arrow_down:
src/client/components/layout/CustomFooter.tsx 100.00% <100.00%> (ø)
src/client/components/layout/index.ts 100.00% <100.00%> (ø)
.../components/pages/Faculty/FacultyScheduleTable.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more