The original button implementation had a disabled prop that prevented the onClick handler from being called, but did not include any stylistic changes to indicate to the user that the button was disabled. In fact the :hover and :active pseudo-classes were still being applied so it appeared as through the button was clicked but nothing was happening. This adds some additional style rules to the :disabled pseudo-class to provide visual cues to the user that the button is disabled.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality
to change)
Checklist:
[x] I have run eslint on the code
[x] I have added JSDoc for all of my code (where applicable)
Describe your changes
The original button implementation had a disabled prop that prevented the onClick handler from being called, but did not include any stylistic changes to indicate to the user that the button was disabled. In fact the
:hoverand:activepseudo-classes were still being applied so it appeared as through the button was clicked but nothing was happening. This adds some additional style rules to the:disabledpseudo-class to provide visual cues to the user that the button is disabled.Types of changes
Checklist:
eslinton the codePriority:
Related Issues:
Fixes #109