search

seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Combobox Shows "No Results" without text input #123

Open jonseitz opened 2 years ago

jonseitz commented 2 years ago

As noted in seas-computing/course-planner#416, the Dropdown button on the Combobox shows a "No Results" message when it's clicked before entering any text in the input box.

===

@jonseitz So, this happens if I click the down arrow beside the dropdown box without typing anything in non rsults . Originally posted by @rmainseas in https://github.com/seas-computing/course-planner/issues/416#issuecomment-946081114

sonusindhu commented 2 years ago

@jonseitz can I work on it and submit a PR? what would be the expected behavior?

We can have two options:

  1. Without entering text, show the 'No data available', if entered text and nothing found, then show current message 'No results for 'text value''
  2. Without entering text, show blank, if entered text and nothing found, then show current message 'No results for 'text value''

Let me know what do you think?

@rmainseas any suggestion