added form prop to the button component - Githubissues

seas-computing / mark-one

A UI component library for building React Apps (in development)

https://seas-computing.github.io/mark-one/

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

added form prop to the button component #133

Closed sonusindhu closed 2 years ago

sonusindhu commented 2 years ago

Describe your changes

Hello Team, this PR is related to the bug for #132

I have added 'form' prop to the Button Component to bind that button with the specific form.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] Added optional 'form' prop to ButtonProps interface
[x] Get 'form' from Button Component props
[x] Bind 'form' prop to the Button
[x] I have run eslint on the code
[x] I have added JSDoc for all of my code (where applicable)
[ ] I have added tests to cover my changes.

Priority:

[x] Normal
[ ] High

Related Issues:

Fixes #132

sonusindhu commented 2 years ago

thanks for the quick review @rmainseas I have updated with the example.

sonusindhu commented 2 years ago

thanks @rmainseas, looking forward to the more contribution.