Closed jonseitz closed 7 months ago
Also, I'm curious as to how you tested this - did you have to downgrade your version of node for the time being? I can't get styleguidist server to run properly on Node 18.
Sort of? I just ran it in a node:14
docker container and was able to get it working:
docker run -it --rm -p 127.0.0.1:6060:6060 -v $(pwd):/node node:14 bash -c "cd /node; npm run start"
I did also play around with upgrading webpack
, styleguidist
, etc for a bit and got it to compile, but any time I tried to load the styleguide there was an error with some kind of polyfill it was trying to apply.
Describe your changes
This adds a
position
prop to the<Footer>
component, which is passed through the the CSS property of same name to allow for customization of the Footer styling. It also changes the default fromfixed
tosticky
, which means that it will "un-float" when the window scrolls to the end of the page content -- that should fix the issue we've sometimes seen with the footer covering up the bottom of the page.Types of changes
Checklist:
eslint
on the codePriority:
Related Issues:
Fixes #161