seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Update types for Modal Footer and Modal Body #176

Closed natalynyu closed 2 months ago

natalynyu commented 2 months ago

This updates the ModalBody and ModalFooter to replace their prop interfaces that only contain the children props and replaces it with PropsWithChildren. This is to fix the error that we are seeing in Makerspace when trying to use ModalBody and ModalFooter:

"Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & ExecutionProps & RefAttributes<IStyledComponent<"web", Substitute<DetailedHTMLProps<HTMLAttributes<HTMLDivElement>, HTMLDivElement>, ModalFooterProps>>>'."

Describe your changes

Types of changes

Checklist:

Priority:

Related Issues:

Fixes #44