search

seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Header Component #21

Closed jonseitz closed 4 years ago

jonseitz commented 4 years ago

Builds out generic Header and Logo components, with tests and docs.

Header uses flexbox to display its children linearly, accepting a justify prop to change the basis by which is flexes and a background prop to change the background from the default value of transparent.

Logo renders an image in the background, and only shows its child text in the DOM (not on screen) for screen reader compatibility.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@a8434ed). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             develop   #21   +/-   ##
=======================================
  Coverage           ?   90%           
=======================================
  Files              ?    16           
  Lines              ?   130           
  Branches           ?     0           
=======================================
  Hits               ?   117           
  Misses             ?    13           
  Partials           ?     0
Impacted Files Coverage Δ
src/Layout/Header.tsx 100% <100%> (ø)
src/index.ts 100% <100%> (ø)
src/Layout/Logo.tsx 100% <100%> (ø)
src/Layout/index.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8434ed...85a8150. Read the comment docs.

jonseitz commented 4 years ago

It looks like the build was failing because of a linting issue on the develop branch. I pushed a fix to there, so it's building correctly now.