seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Icon Link UI Component #30

Closed natalynyu closed 4 years ago

natalynyu commented 4 years ago

This is a draft of the Icon Link component - Ticket #120

Types of changes

Checklist:

Priority:

Related Issues:

Addresses #120

codecov[bot] commented 4 years ago

Codecov Report

Merging #30 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #30   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           21     23    +2     
  Lines          159    171   +12     
======================================
+ Hits           159    171   +12
Impacted Files Coverage Δ
src/Icons/index.ts 100% <100%> (ø)
src/index.ts 100% <100%> (ø) :arrow_up:
src/Icons/IconLink.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32ecdb2...3a79b0a. Read the comment docs.

rmainwork commented 4 years ago
diff --git a/.eslintrc.json b/.eslintrc.json
index d414b29..5b8c2db 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -149,6 +149,7 @@
   ],
   "settings": {
     "import/resolver": {
+      "node": {},
       "webpack": {
         "config": {
           "resolve": {

Should fix the eslint resolver issue you were having with assert :)