seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Reconfigure mark one for consumption by external projects #33

Closed rmainwork closed 4 years ago

rmainwork commented 4 years ago
codecov[bot] commented 4 years ago

Codecov Report

Merging #33 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #33   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           25     19    -6     
  Lines          183    178    -5     
  Branches         0     16   +16     
======================================
- Hits           183    178    -5
Impacted Files Coverage Δ
src/Button/BasicButton.tsx 100% <ø> (ø) :arrow_up:
src/Tables/TableCell.tsx 100% <ø> (ø) :arrow_up:
src/Theme/GlobalCSS.tsx 100% <ø> (ø) :arrow_up:
src/Layout/Header.tsx 100% <ø> (ø) :arrow_up:
src/Tables/Table.tsx 100% <ø> (ø) :arrow_up:
src/Icons/IconLink.tsx 100% <ø> (ø) :arrow_up:
src/Layout/Logo.tsx 100% <ø> (ø) :arrow_up:
src/Dropdown/Dropdown.tsx 100% <ø> (ø) :arrow_up:
src/Tables/TableHead.tsx 100% <ø> (ø) :arrow_up:
src/Layout/PageBody.tsx 100% <ø> (ø) :arrow_up:
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8478d8...0ebb33b. Read the comment docs.

rmainwork commented 4 years ago

Thinking about this some more, the only concern I might have about updating the examples folder like I did in 826553a would mean that the examples aren't quite examples that you can copy/paste any more.

So, maybe 826553a should be reverted, and the mark-one alias put back just for the purposes of the styleguide? Open to suggestions on this though...

jonseitz commented 4 years ago

@rmainseas Yeah, I think you've raised a good point about the pastability of the example code. Let's revert for the examples, keep the alias, and make sure we're vigilant about using relative imports in future code reviews