seas-computing / mark-one

A UI component library for building React Apps (in development)

https://seas-computing.github.io/mark-one/

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

Button Variants #34

Closed natalynyu closed 4 years ago

natalynyu commented 4 years ago

This PR includes the creation of 4 button variants: Primary, Secondary, Danger, and Borderless. This was done by extending the BasicButton component

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run eslint on the code
[x] I have added JSDoc for all of my code (where applicable)
[x] I have added tests to cover my changes.

Priority:

[x] Normal
[ ] High

Related Issues:

Addresses #34

codecov[bot] commented 4 years ago

Codecov Report

Merging #34 into develop will not change coverage by %. The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          223       223           
  Branches        18        18           
=========================================
  Hits           223       223

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20d8b7d...20d8b7d. Read the comment docs.

natalynyu commented 4 years ago

All buttons were exported through commit a36b12e. Tests to make sure that click handler isn't called when disabled is truthy on the button were added through 61e7644. Thanks!