seas-computing / mark-one

A UI component library for building React Apps (in development)
https://seas-computing.github.io/mark-one/
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Validation Error Message Component #37

Closed natalynyu closed 4 years ago

natalynyu commented 4 years ago

This component will be used in our Text Input component and other input components to display validation errors.

Types of changes

Checklist:

Priority:

Related Issues:

Addresses #147

codecov-io commented 4 years ago

Codecov Report

Merging #37 into develop will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        20    +1     
  Lines          178       190   +12     
  Branches        16        17    +1     
=========================================
+ Hits           178       190   +12     
Impacted Files Coverage Δ
src/Forms/ValidationErrorMessage.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13f42fb...8079a76. Read the comment docs.

natalynyu commented 4 years ago

@jonseitz I tried to move this component into src/Forms instead, and I'm getting the error in index.ts and a similar error in the component file: Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser. The file does not match your project config: src/Forms/ValidationErrorMessage/index.ts. The file must be included in at least one of the projects provided.

I'm looking into how to fix this now!