Closed natalynyu closed 4 years ago
:exclamation: No coverage uploaded for pull request base (
develop@bec00f2
). Click here to learn what that means. The diff coverage is100%
.
@@ Coverage Diff @@
## develop #39 +/- ##
========================================
Coverage ? 100%
========================================
Files ? 25
Lines ? 324
Branches ? 27
========================================
Hits ? 324
Misses ? 0
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
src/Forms/ValidationErrorMessage.tsx | 100% <ø> (ø) |
|
src/Theme/index.ts | 100% <100%> (ø) |
|
src/Forms/TextInput.tsx | 100% <100%> (ø) |
|
src/Forms/Label.tsx | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bec00f2...1351197. Read the comment docs.
I'm approving my part of these.
This looks good! Great job incorporating all those changes. I think should be all set to merge.
This is the Text Input component, which integrates the ValidationErrorMessage component in it. The styling of this component is based off of the text input fields in the Course Planning app.
Types of changes
Checklist:
eslint
on the codePriority:
Related Issues:
Addresses #123