seas-computing / mark-one

A UI component library for building React Apps (in development)

https://seas-computing.github.io/mark-one/

BSD 3-Clause "New" or "Revised" License

0 stars 1 forks source link

Update VARIANT import to have relative paths #41

Closed natalynyu closed 4 years ago

natalynyu commented 4 years ago

Instead of importing VARIANT enum directly from the Theme path, update the path to be relative to solve course-planner import error in which the Button and BorderlessButton components could not be found.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run eslint on the code
[x] I have added JSDoc for all of my code (where applicable)
[ ] I have added tests to cover my changes.

Priority:

[x] Normal
[ ] High

Related Issues:

Addresses #117

codecov[bot] commented 4 years ago

Codecov Report

Merging #41 into develop will not change coverage by %. The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          222       222           
  Branches        18        18           
=========================================
  Hits           222       222

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 243ea28...376f27c. Read the comment docs.

natalynyu commented 4 years ago

This looks fine, but we should also update the import lines in the test files for both of these as well.

Sorry, I should have thought of that - fixed through 376f27c.